Fix importer crash #1541 - #1542
Merged
Merged
Conversation
Reference: #1541 Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Use the latest date file from nginx Reference: #1541 Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Otherwise the VulnerabilitySeverity.published_at data will be an invalid "None" string. Reference: #1541 Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
pombredanne
force-pushed
the
1541-fix-importer-crash
branch
from
August 9, 2024 15:16
3b5e5f6 to
be28af3
Compare
Member
Author
ziadhany
approved these changes
Aug 12, 2024
ziadhany
left a comment
ziadhany
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, and I apologize for introducing this bug.
| except Exception as e: | ||
| logger.info(f"Failed to process advisory: {advisory!r} with error {e!r}") | ||
| except Exception: | ||
| from pprint import pformat |
Collaborator
There was a problem hiding this comment.
@pombredanne Would it be better to move the pprint library import to the top of the code?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is correction for the crash in #1541
The issue was introduced by this commit 0fe73ef#diff-11856d929972b1aa71dcd476298a831d6b598b291c0638057af6d62050ba4a15R192
We now check for empty published_at before using it. Otherwise the VulnerabilitySeverity.published_at data will be an invalid "None" string resulting from
str(None).Also improve logging.