Update dep versions and make test pass - #42
Merged
Merged
Conversation
singh1114
commented
Apr 6, 2019
singh1114
commented
Contributor
- Django has released newer versions with some security patches and new updates.
- Bumping versions of other things as well.
Signed-off-by: Ranvir Singh <ranvir.singh1114@gmail.com>
Signed-off-by: Ranvir Singh <ranvir.singh1114@gmail.com>
Signed-off-by: Ranvir Singh <ranvir.singh1114@gmail.com>
Signed-off-by: Ranvir Singh <ranvir.singh1114@gmail.com>
singh1114
commented
Apr 6, 2019
singh1114
commented
Apr 6, 2019
| in a package repository, such as a Debian, Maven or NPM repository. | ||
| """ | ||
| package = models.ForeignKey('Package') | ||
| package = models.ForeignKey(Package, on_delete=models.CASCADE) |
Contributor
Author
There was a problem hiding this comment.
Using classes as ForeignKeys rather than strings.
singh1114
commented
Apr 6, 2019
singh1114
commented
Apr 6, 2019
|
|
||
| if 'TRAVIS' in os.environ: | ||
| DATABASES['default']['USER'] = 'postgres' | ||
| DATABASES['default']['PASSWORD'] = '' |
Contributor
Author
There was a problem hiding this comment.
Defaults for travisCI.
pombredanne
requested changes
Apr 6, 2019
pombredanne
left a comment
pombredanne
left a comment
Member
There was a problem hiding this comment.
Thanks++ you made this green again... excellent!
See some review comments.
| ``` | ||
| python3.6 -m venv . | ||
| source bin/activate | ||
| python3 -m venv venv |
Member
There was a problem hiding this comment.
why calling the virtualenv directory venv and pushing it one level down?
| - Get Python 3.6+ installed first and pip (pip is included in the | ||
| Python.org downloads since Python 2.7.9) | ||
|
|
||
| - Install PostgreSQL 11.2 of later. (11.2 preferred) |
Member
There was a problem hiding this comment.
I am not sure we have any such requirement to get the latest Postgres, do we?
Signed-off-by: Ranvir Singh <ranvir.singh1114@gmail.com>
pombredanne
pushed a commit
that referenced
this pull request
Apr 2, 2025
Fixed #41 - Handled encoding issue when generating ABOUT files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.