Added type checking in CI - #640
Closed
abhishak3 wants to merge 2 commits into
Closed
Conversation
Signed-off-by: Abhishek <abhishek.pandey.3237@gmail.com>
Collaborator
|
@abhishak3 ping! failing tests |
Signed-off-by: Abhishek <abhishek.pandey.3237@gmail.com>
Author
Author
|
@Hritik14 can you please have a look at my pr and approve it maybe? |
Collaborator
|
@abhishak3 We'll need to fix/mark expected failure the failing test this has introduced in order to move on. |
Member
|
@abhishak3 I cannot merge this unless this is passing all the tests correctly without first having to change all the code. |
Author
|
any suggestions on how to do this ? |
Member
|
@abhishak3 I have not the start of an idea. |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #226
Signed-off-by: Abhishek abhishek.pandey.3237@gmail.com