Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move aiida-core~=2.6 dependency to dev #181

Closed
wants to merge 1 commit into from

Conversation

edan-bainglass
Copy link
Member

This PR reverts the aiida-core dependency back to ~=2.1 and moves the ~=2.6 pin to dev dependencies. See resolved issue for detail.

Resolves #180

Keep old `aiida-core~=2.1` dependency
@sphuber
Copy link
Contributor

sphuber commented Dec 23, 2024

Unfortunately it is not so easy. There were a number of changes in the API of aiida-core in v2.6 that we already adjusted to, amongst which the hashing. See bcc0129

The issue says

However, this dependency leads to conflicts with packages using aiida-pseudo that have yet to upgrade.

What are the specific problems? I think we should rather work to fix those than revert here.

@edan-bainglass
Copy link
Member Author

The issue says

However, this dependency leads to conflicts with packages using aiida-pseudo that have yet to upgrade.

What are the specific problems? I think we should rather work to fix those than revert here.

I'll let @superstar54 explain. It was mostly a concern for those who use older versions of aiida-core AND aiida-pseudo.

As for the particular issue at hand, we're trying to release aiidalab-qe. All of our tests are running into an issue with aiida-pseudo w.r.t downloading the pseudos. This was "fixed" in #179, which already includes the ~=2.6 pin. This is now causing issues with the release due to aiidalab dependencies, but let me see if I can overcome those issues. I think it has already been tested with 2.6 and a new image is available. I'll check.

@superstar54
Copy link
Member

Hi @sphuber , thanks for the quick comment.

What are the specific problems? I think we should rather work to fix those than revert here.

We want to use aiida-pseudo inside the AiiDAlab docker image, which fixs aiida-core version==2.5.1.

@superstar54
Copy link
Member

We avoid the issue by using the latest AiiDAlab full-stack image with aiida-core 2.6.

As discussed with @edan-bainglass , we closed this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency conflict
3 participants