-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support cards/day limit in FSRS optimizer #3046
Comments
@abdnh another one for you if you're interested |
I got confused by "optimizer" in the title. I assume the issue is about the frontend part of #3075. In addition to exposing the simulation inputs in the GUI, we need to graph the results (probably in a popup window). |
I'll need to defer to @L-M-Sherlock on this, as the simulator has been changed a few times. When writing this ticket, I was under the impression we'd just need to expose those two values, but I'm not sure how they fit in now / how things will change if we add a built-in graphing simulator in the future. |
These two values should be exposed in the built-in simulator in the future. |
So, to confirm, you're saying there's nothing we should do for now? |
Yeah. The current finding optimal retention feature doesn't require it. |
This issue could be closed. |
open-spaced-repetition/fsrs-rs#141
We need to expose learn_limit and review_limit in the GUI, and make it a union with the daily cost setting: open-spaced-repetition/fsrs-rs#141 (comment)
The text was updated successfully, but these errors were encountered: