Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support cards/day limit in FSRS optimizer #3046

Closed
dae opened this issue Mar 3, 2024 · 7 comments
Closed

Support cards/day limit in FSRS optimizer #3046

dae opened this issue Mar 3, 2024 · 7 comments
Labels

Comments

@dae
Copy link
Member

dae commented Mar 3, 2024

open-spaced-repetition/fsrs-rs#141

We need to expose learn_limit and review_limit in the GUI, and make it a union with the daily cost setting: open-spaced-repetition/fsrs-rs#141 (comment)

@dae dae added the FSRS label Mar 3, 2024
@dae
Copy link
Member Author

dae commented Mar 3, 2024

@abdnh another one for you if you're interested

@abdnh
Copy link
Collaborator

abdnh commented Apr 3, 2024

I got confused by "optimizer" in the title. I assume the issue is about the frontend part of #3075. In addition to exposing the simulation inputs in the GUI, we need to graph the results (probably in a popup window).

@dae
Copy link
Member Author

dae commented Apr 4, 2024

I'll need to defer to @L-M-Sherlock on this, as the simulator has been changed a few times. When writing this ticket, I was under the impression we'd just need to expose those two values, but I'm not sure how they fit in now / how things will change if we add a built-in graphing simulator in the future.

@L-M-Sherlock
Copy link
Contributor

These two values should be exposed in the built-in simulator in the future.

@dae
Copy link
Member Author

dae commented Apr 5, 2024

So, to confirm, you're saying there's nothing we should do for now?

@L-M-Sherlock
Copy link
Contributor

Yeah. The current finding optimal retention feature doesn't require it.

@L-M-Sherlock
Copy link
Contributor

This issue could be closed.

@dae dae closed this as completed Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants