Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](compile) fix FE compilation issue due to missing pom dependency #46511

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[fix](compile) fix FE compilation issue due to missing pom dependency #46511

wants to merge 1 commit into from
+12 −0

Conversation

yongjinhou
Copy link
Contributor

@yongjinhou yongjinhou commented Jan 7, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: close #46510

Related PR: #xxx

Problem Summary:
fix FE compilation issue due to missing pom dependency

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@yongjinhou
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32972 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ae84855b7d00269649ce3b25d86d211a18ecf36b, data reload: false

------ Round 1 ----------------------------------
q1	17623	6321	6080	6080
q2	2050	304	174	174
q3	10504	1338	746	746
q4	10219	886	457	457
q5	7513	2303	2035	2035
q6	207	185	147	147
q7	930	777	630	630
q8	9221	1395	1181	1181
q9	5363	4927	4973	4927
q10	6766	2311	1867	1867
q11	473	287	274	274
q12	352	369	229	229
q13	17768	3724	3129	3129
q14	238	236	221	221
q15	571	508	493	493
q16	641	616	593	593
q17	609	872	339	339
q18	7236	6454	6326	6326
q19	2596	979	592	592
q20	310	331	191	191
q21	2958	2234	2021	2021
q22	366	331	320	320
Total cold run time: 104514 ms
Total hot run time: 32972 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6403	6254	6281	6254
q2	235	323	229	229
q3	2275	2682	2377	2377
q4	1546	1942	1477	1477
q5	4388	4803	5081	4803
q6	198	185	147	147
q7	2112	1991	1778	1778
q8	2682	2834	2732	2732
q9	7241	7182	7260	7182
q10	3071	3315	2839	2839
q11	597	527	511	511
q12	654	813	604	604
q13	3555	3911	3247	3247
q14	275	317	282	282
q15	574	508	508	508
q16	699	692	657	657
q17	1224	1771	1260	1260
q18	7820	7487	6981	6981
q19	862	1129	1091	1091
q20	1905	2001	1836	1836
q21	5725	5155	4818	4818
q22	611	605	564	564
Total cold run time: 54652 ms
Total hot run time: 52177 ms

@yongjinhou
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 33868 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ae84855b7d00269649ce3b25d86d211a18ecf36b, data reload: false

------ Round 1 ----------------------------------
q1	17702	6407	6264	6264
q2	2046	329	172	172
q3	10387	1375	751	751
q4	10221	916	457	457
q5	7542	2381	2183	2183
q6	239	187	148	148
q7	950	768	619	619
q8	9241	1514	1349	1349
q9	5794	5234	5115	5115
q10	6907	2366	1886	1886
q11	504	291	256	256
q12	386	393	218	218
q13	17791	3888	3066	3066
q14	242	238	210	210
q15	573	515	525	515
q16	637	626	579	579
q17	602	916	346	346
q18	7064	6659	6545	6545
q19	1245	1114	592	592
q20	331	341	193	193
q21	3270	2357	2092	2092
q22	369	346	312	312
Total cold run time: 104043 ms
Total hot run time: 33868 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6580	6568	6595	6568
q2	250	347	240	240
q3	2343	2760	2331	2331
q4	1551	1925	1420	1420
q5	4432	4896	4820	4820
q6	202	180	140	140
q7	2065	1939	1756	1756
q8	2740	2904	2892	2892
q9	7113	6930	6989	6930
q10	3069	3293	2756	2756
q11	623	523	490	490
q12	683	770	568	568
q13	3516	3856	3076	3076
q14	280	300	270	270
q15	562	496	501	496
q16	667	709	649	649
q17	1275	1837	1248	1248
q18	7361	7245	7110	7110
q19	888	973	1302	973
q20	1999	2061	1856	1856
q21	5753	5059	4889	4889
q22	633	613	541	541
Total cold run time: 54585 ms
Total hot run time: 52019 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 190624 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ae84855b7d00269649ce3b25d86d211a18ecf36b, data reload: false

query1	900	384	378	378
query2	5325	2451	2442	2442
query3	5760	210	214	210
query4	33158	23555	23850	23555
query5	3430	614	470	470
query6	257	204	184	184
query7	4354	511	304	304
query8	306	256	236	236
query9	8419	2787	2764	2764
query10	418	313	252	252
query11	18107	15398	15237	15237
query12	163	109	107	107
query13	1575	549	414	414
query14	10260	6845	6683	6683
query15	278	193	201	193
query16	7917	618	445	445
query17	1453	737	585	585
query18	2123	404	341	341
query19	243	175	152	152
query20	120	114	118	114
query21	205	125	104	104
query22	4379	4293	4287	4287
query23	34791	34784	33550	33550
query24	6714	2268	2245	2245
query25	462	430	386	386
query26	1050	257	155	155
query27	2481	461	327	327
query28	5669	2464	2450	2450
query29	524	533	409	409
query30	273	184	148	148
query31	967	897	828	828
query32	83	65	61	61
query33	509	351	286	286
query34	743	855	490	490
query35	798	819	751	751
query36	1059	1027	980	980
query37	121	100	86	86
query38	4064	4269	4035	4035
query39	1513	1624	1456	1456
query40	197	114	98	98
query41	46	44	45	44
query42	128	105	102	102
query43	528	559	500	500
query44	1277	813	796	796
query45	177	174	172	172
query46	883	1043	638	638
query47	1927	1922	1864	1864
query48	376	408	321	321
query49	808	469	400	400
query50	657	647	381	381
query51	7146	7065	7275	7065
query52	100	105	93	93
query53	227	250	202	202
query54	492	486	405	405
query55	79	80	82	80
query56	243	269	246	246
query57	1214	1196	1131	1131
query58	241	224	238	224
query59	3027	3071	2904	2904
query60	275	262	275	262
query61	114	115	117	115
query62	837	797	745	745
query63	227	195	193	193
query64	4289	985	685	685
query65	3314	3236	3240	3236
query66	949	417	324	324
query67	15879	15811	15532	15532
query68	8461	702	515	515
query69	461	298	253	253
query70	1216	1146	1151	1146
query71	449	278	251	251
query72	6408	3844	3885	3844
query73	646	756	367	367
query74	10025	9331	8911	8911
query75	3872	3095	2681	2681
query76	3563	1182	756	756
query77	702	366	289	289
query78	10171	10179	9469	9469
query79	3221	792	606	606
query80	623	526	435	435
query81	488	331	230	230
query82	567	150	132	132
query83	166	163	150	150
query84	233	87	69	69
query85	814	360	308	308
query86	422	326	314	314
query87	4571	4486	4306	4306
query88	4780	2239	2207	2207
query89	407	345	299	299
query90	1866	204	195	195
query91	139	139	108	108
query92	71	56	54	54
query93	1808	875	534	534
query94	665	405	289	289
query95	330	262	252	252
query96	491	610	282	282
query97	2878	3019	2864	2864
query98	263	198	194	194
query99	1498	1571	1456	1456
Total cold run time: 288903 ms
Total hot run time: 190624 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.84 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ae84855b7d00269649ce3b25d86d211a18ecf36b, data reload: false

query1	0.03	0.03	0.05
query2	0.08	0.04	0.03
query3	0.24	0.07	0.07
query4	1.61	0.11	0.11
query5	0.43	0.42	0.43
query6	1.16	0.66	0.65
query7	0.02	0.02	0.01
query8	0.04	0.03	0.03
query9	0.61	0.50	0.50
query10	0.55	0.57	0.55
query11	0.14	0.10	0.10
query12	0.14	0.11	0.11
query13	0.62	0.62	0.60
query14	2.73	2.76	2.76
query15	0.88	0.83	0.82
query16	0.37	0.39	0.37
query17	1.10	0.99	1.06
query18	0.23	0.21	0.21
query19	1.85	1.84	1.95
query20	0.01	0.01	0.01
query21	15.36	0.92	0.60
query22	0.74	0.83	0.70
query23	15.22	1.39	0.58
query24	3.43	1.25	0.45
query25	0.13	0.17	0.09
query26	0.35	0.16	0.13
query27	0.07	0.07	0.05
query28	13.51	1.60	1.05
query29	12.56	3.89	3.24
query30	0.25	0.09	0.06
query31	2.82	0.59	0.39
query32	3.24	0.53	0.46
query33	3.11	3.10	3.18
query34	16.55	5.17	4.49
query35	4.54	4.46	4.61
query36	0.65	0.49	0.48
query37	0.09	0.06	0.05
query38	0.05	0.04	0.03
query39	0.04	0.03	0.02
query40	0.17	0.14	0.13
query41	0.08	0.03	0.02
query42	0.03	0.03	0.02
query43	0.03	0.03	0.03
Total cold run time: 105.86 s
Total hot run time: 30.84 s

chenlinzhong
chenlinzhong approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@chenlinzhong chenlinzhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

HappenLee
HappenLee approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 7, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 7, 2025

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 7, 2025

PR approved by anyone and no changes requested.

@yongjinhou
Copy link
Contributor Author

run Need_2_Approval

@yongjinhou
Copy link
Contributor Author

run arm

@morningman
Copy link
Contributor

Looks like you pom file is broken

[WARNING] The POM for com.azure:azure-storage-blob:jar:12.28.1 is invalid, transitive dependencies (if any) will not be available, enable debug logging for more details
[WARNING] The POM for com.azure:azure-identity:jar:1.14.0 is invalid, transitive dependencies (if any) will not be available, enable debug logging for more details
[WARNING] The POM for com.azure:azure-storage-blob-batch:jar:12.22.0 is invalid, transitive dependencies (if any) will not be available, enable debug logging for more details

Please check them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenlinzhong chenlinzhong chenlinzhong approved these changes

@HappenLee HappenLee HappenLee approved these changes

@CalvinKirs CalvinKirs Awaiting requested review from CalvinKirs CalvinKirs is a code owner

@morningman morningman Awaiting requested review from morningman morningman is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement] fix FE compilation issue due to missing pom dependency
6 participants
@yongjinhou @hello-stephen @doris-robot @morningman @HappenLee @chenlinzhong