Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Refactor GravitinoCommandLine into multiple classes #6138

Open
12 tasks
justinmclean opened this issue Jan 8, 2025 · 3 comments
Open
12 tasks

[Improvement] Refactor GravitinoCommandLine into multiple classes #6138

justinmclean opened this issue Jan 8, 2025 · 3 comments
Labels
good first issue Good for newcomers improvement Improvements on everything

Comments

@justinmclean
Copy link
Member

justinmclean commented Jan 8, 2025 •
edited
Loading

What would you like to be improved?

GravitinoCommandLine class is getting a little large and could be broken up.

How should we improve?

Move each entity command into it's class.
@justinmclean justinmclean added good first issue Good for newcomers improvement Improvements on everything labels Jan 8, 2025
@Abyss-lord
Copy link
Contributor

I would like to work on it when #6140 merged.

@luoshipeng
Copy link
Contributor

I'd like to work on it. if the subtask is created, assign it to me pls

@justinmclean
Copy link
Member Author

justinmclean commented Jan 8, 2025 •
edited
Loading

Thanks for the offer to help @Abyss-lord you can do #6143, @luoshipeng #6144. Just follow the metalake refactor (#6139) as an example of what to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers improvement Improvements on everything
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@justinmclean @luoshipeng @Abyss-lord