Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression testing #111

Open
aradhakrishnanGFDL opened this issue Mar 26, 2024 · 0 comments
Open

regression testing #111

aradhakrishnanGFDL opened this issue Mar 26, 2024 · 0 comments
Assignees

Comments

@aradhakrishnanGFDL
Copy link
Owner

We once encountered a bug that went unnnoticed..where variable_id was missing in the catalog, so this is an error that could have only been captured after when open the catalog.

we need a simple regression test.

1- Have a "golden" standard catalog that comes out of the catalog builder right now. Name it appropriately to give it the version, tag or something to know which version of the code generated that for documentation purposes.

2- extend the create-gfdl-catalog CI workflow to include the following after a code change.
--- simply check the output json and csv with the golden standard in the github repo (ignoring the url to the csv).

this will quickly reveal if a column or value was left out , then gives a chance to assess if that was intended or not.

3- leverage pytest to do this and actions workflow to do this. Will need the addition of the golden standard catalogs, which can be accessed from github from a recent create-gfdl-catalog output (called manifests in github where i save the json and csv)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants