-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
catalog vocabulary slightly incompatible with example analysis script usage #120
Comments
--> The keys in the returned dictionary of datasets are constructed as follows:
|
@ceblanton member_id is empty "" , when it's empty the logic in Ray's script perhaps should be to remove it in key name? |
or we enforce no null which may be something we discussed before. |
on May 9th, it was decided to use "na" as the default value for the aggregate columns rather than the empty values, to help maintain a "key pattern" at the early stage of adopting this. Down the line, we will provide examples to dynamically query for the dataset/key names. |
PR is ready for member_id to be "na" by default. But, I realize Ray's key still is missing the chunk frequency which is an aggregate column. I am not sure if leaving it in the key or using a default for chunk_freq is a good idea. We can't possibly find unique datasets without that. But this also circles back to not having to hard-code these key names. this now works: am5.c96L65_am5f7b11r0_amip.P1M.na.atmos_level.high_cld_amt.P1Y You can test:
|
figure generated : /nbhome/a1r/analysis-scripts/pngs/cloud-fraction.png script used: https://github.com/aradhakrishnanGFDL/analysis-scripts/blob/prototype1-a1r/raytest.py changes made are in my fork https://github.com/aradhakrishnanGFDL/analysis-scripts/tree/prototype1-a1r/freanalysis_clouds |
to support this, we need to remove source_id from the aggregation columns. MDTF uses it though. so let's discuss.. @ceblanton |
FRE Canopy is generating catalogs using:
module load fre/canopy
fre catalog build --overwrite -i $ppdir -o $ppdir/catalog
sed -i.bak -e 's/,P1M,/,monthly,/' $ppdir/catalog.csv
An example pp directory and catalog file are here:
The example analysis script usage (the Ray example) is:
That fails with this message
The mystery is that this very-similar catalog works:
/net2/rlm/analysis-scripts/example/catalog.json
The difference we think is "n/a" versus missing for the ensemble vocabulary.
Hopefully, the "fre catalog validate /path/to/schema.json /path/to/catalog-to-test.json" usage can detect this mismatch or inconsistency before we try to launch the script.
The text was updated successfully, but these errors were encountered: