Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catalog builder in a Docker container #46

Open
aradhakrishnanGFDL opened this issue Jan 29, 2024 · 2 comments
Open

Catalog builder in a Docker container #46

aradhakrishnanGFDL opened this issue Jan 29, 2024 · 2 comments
Assignees
Milestone

Comments

@aradhakrishnanGFDL
Copy link
Owner

aradhakrishnanGFDL commented Jan 29, 2024

An automated workflow to build a docker image of the catalog builder.
Ease of use for users using any platform.

@aradhakrishnanGFDL
Copy link
Owner Author

aradhakrishnanGFDL commented Jan 29, 2024

@Ciheim--

Associated workflow https://github.com/aradhakrishnanGFDL/CatalogBuilder/actions/runs/7699963455/job/20982717615

This needs testing, and notes documented before the issue can be closed.
Once manual testing is complete, close this issue. Open new issue to update GitHub actions workflows to include an automated test for the docker container.

Manual testing

Run:

docker pull aparnadotnoaa/catalogbuilder-image:latest

make sure it's public
make sure it can generate a GFDL catalog (meaning, it can load the env and run the gfdl wrapper script successfully, generating json and csv)
Sanity testing needed for json and csv, just diff with the same experiment for which catalog was generated using the conda package, or the git repo.

Update testing notes in this issue with the docker run or exec commands.
Update README for users to use this container at GFDL, and outside of GFDL.

@aradhakrishnanGFDL
Copy link
Owner Author

awaits testing

@aradhakrishnanGFDL aradhakrishnanGFDL moved this from In progress to In review in Catalog builder for GFDL analysis Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In review
Development

No branches or pull requests

1 participant