Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bench-deploy: Convert between Criterion JSON formats #52

Open
samuelburnham opened this issue Mar 1, 2024 · 0 comments
Open

bench-deploy: Convert between Criterion JSON formats #52

samuelburnham opened this issue Mar 1, 2024 · 0 comments

Comments

@samuelburnham
Copy link
Member

After #44

Currently, our gh-pages benchmark JSONs can't be used with criterion-table and our commit-comment benchmarks can't be used in plots. After some testing I've found that reformatting the JSON files is fairly straightforward using jq. This would have several benefits:

  • Run only one benchmark per commit, rather than fiddling with env vars to produce several for use in our various comparison tools. This saves time and UX hassle
  • Cached commit-comment benchmarks could be immediately deployed when a PR is merged, rather than having to re-run the benchmark in the gh-pages format for plotting & deployment. This saves time, runner resources and clutter in gh-pages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant