Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eos_ip_routing_enabled should not have a default value #19

Open
mnarusze opened this issue Mar 21, 2018 · 1 comment
Open

eos_ip_routing_enabled should not have a default value #19

mnarusze opened this issue Mar 21, 2018 · 1 comment

Comments

@mnarusze
Copy link

Yesterday I was testing setting hostname and users on my local dev environment and was surprised to find out that apart from the desired changes, the role disabled ip routing. My bad in not reading the full documentation before launching the role but I didn't expect such a risky default to be there.

In my opinion, there should be no default value for eos_ip_routing_enabled so that if it's skipped in host vars, the current configuration stays.

@dathelen
Copy link

@mnarusze Thanks for the feedback. We will discuss this issue during our next meeting and will update this thread with our plan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants