Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codebase is not compliant with lint #153

Open
eliwu64 opened this issue Nov 28, 2019 · 0 comments
Open

Codebase is not compliant with lint #153

eliwu64 opened this issue Nov 28, 2019 · 0 comments

Comments

@eliwu64
Copy link

eliwu64 commented Nov 28, 2019

The codebase fails the Gradle lint check with 4 errors and 393 warnings that have accumulated over time, some of which are release-blocking. We need to fix these errors and, in the future, mandate that all changes pass lint before they can be submitted.

https://developer.android.com/studio/write/lint

Errors:

Task :app:lintVitalRelease
/bitrise/src/app/src/main/res/layout/fragment_calendar.xml:13: Error: @+id/toolbar is not a sibling in the same RelativeLayout [NotSibling]
android:layout_below="@+id/toolbar"

Task :app:lint
Correctness
--
1 | warning NestedScrolling: Nested scrolling widgets
1 | warning CommitPrefEdits: Missing commit() on SharedPreference editor
10 | warning DefaultLocale: Implied default locale in case conversion
2 | error InvalidPackage: Package not included in Android
3 | warning SimpleDateFormat: Implied locale in date format
1 | warning UnusedAttribute: Attribute unused on older versions
1 | error ProtectedPermissions: Using system app permission
13 | warning GradleDependency: Obsolete Gradle Dependency
1 | error RestrictedApi: Restricted API
11 | warning SpUsage: Using dp instead of sp for text sizes
  | Security
1 | warning UnsafeProtectedBroadcastReceiver: Unsafe Protected BroadcastReceiver
2 | warning ExportedService: Exported service does not require permission
1 | warning AllowBackup: AllowBackup/FullBackupContent Problems
  | Performance
18 | warning ObsoleteLayoutParam: Obsolete layout params
7 | warning ObsoleteSdkInt: Obsolete SDK_INT Version Check
10 | warning StaticFieldLeak: Static Field Leaks
9 | warning UseCompoundDrawables: Node can be replaced by a TextView with compound drawables
1 | warning ViewHolder: View Holder Candidates
1 | warning UseOfBundledGooglePlayServices: Use of bundled version of Google Play services
1 | warning InefficientWeight: Inefficient layout weight
6 | warning Overdraw: Overdraw: Painting regions more than once
42 | warning UnusedResources: Unused resources
7 | warning UselessParent: Useless parent layout
18 | warning RedundantNamespace: Redundant namespace
14 | warning UnusedNamespace: Unused namespace
  | Usability:Icons
1 | warning IconNoDpi: Icon appears in both -nodpi and dpi folders
10 | warning IconDipSize: Icon density-independent size validation
12 | warning IconDuplicatesConfig: Identical bitmaps across various configurations
37 | warning IconLocation: Image defined in density-independent drawable folder
4 | warning IconDensities: Icon densities validation
  | Usability
7 | warning ButtonStyle: Button should be borderless
1 | warning GoogleAppIndexingWarning: Missing support for Firebase App Indexing
  | Accessibility
2 | warning ClickableViewAccessibility: Accessibility in Custom Views
20 | warning ContentDescription: Image without contentDescription
10 | warning KeyboardInaccessibleWidget: Keyboard inaccessible widget
  | Internationalization
3 | warning SetTextI18n: TextView Internationalization
42 | warning HardcodedText: Hardcoded text
  | Internationalization:Bidirectional Text
4 | warning RtlSymmetry: Padding and margin symmetry
61 | warning RtlHardcoded: Using left/right instead of start/end attributes
1 | warning RtlEnabled: Using RTL attributes without enabling RTL support

@eliwu64 eliwu64 added the bug label Nov 28, 2019
@eliwu64 eliwu64 self-assigned this Nov 28, 2019
@eliwu64 eliwu64 changed the title Develop branch fails Lint for release Develop branch fails Gradle Lint check Nov 28, 2019
@eliwu64 eliwu64 changed the title Develop branch fails Gradle Lint check Develop branch fails Gradle Lint Nov 28, 2019
@eliwu64 eliwu64 changed the title Develop branch fails Gradle Lint Codebase fails lint Nov 28, 2019
@eliwu64 eliwu64 added the bug label Nov 28, 2019
@eliwu64 eliwu64 changed the title Codebase fails lint Codebase is not compliant with lint Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant