fix: subscription button modified #217 #222
Conversation
✅ Deploy Preview for peaceful-ramanujan-288045 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
AceTheCreator
changed the title
|
@Mayaleeeee what do you think? |
|
I think my solution modifies the subscription button to look exactly like other buttons in the project. If you have any feedback please let me know I will work on that. |
Thank you @AyushmanSinghRajawat It looks perfect on the web but is not well positioned on the mobile version. It should be centre-aligned with the same length as the "All" button under the speakers' section @AyushmanSinghRajawat. cc @AceTheCreator, I noticed that the buttons on the mobile version of the website are different in length. In particular, they should all be the same length as the "ALL" button under the speakers' section. Should I open a separate issue, or can we handle it under this PR? |
Hi @AyushmanSinghRajawat, thank you for working on this. I have reviewed your work and provided my feedback. |
|
Thank you @Mayaleeeee for reviewing my work, I can center-align the subscribe button with same length as "All" button. Should I also change the length of all buttons in mobile version? if yes, please let me know, i will make the changes ASAP. |
Yes, please. You can do that. wdy @AceTheCreator |
This should be in a different PR |
|
|
ok @AceTheCreator @Mayaleeeee , so for now i should just fix the subscribe button alignment and size, right? and can I raise a new issue for the new PR? I am new to open source so I truly appreciate any guidance from your side. |
Yeah, adjust the alignment and size of the subscribe button in this PR And submit another PR for fixing the sizing of all buttons in the mobile version. Please, feel free to reach out if you require any further assistance. |
|
|
|
@Mayaleeeee is this okay? |
Yes, boss. Thank you @AyushmanSinghRajawat |
|
Kindly merge my PR @AceTheCreator @Mayaleeeee |
|
@AyushmanSinghRajawat so sorry for the late response 🙏🏾 Can you make this branch up-to-date with the master? so I can go ahead and merge it ✌🏾 |
|
Hey @AceTheCreator I have updated this branch. You can merge this PR now. |
|
hey, @AceTheCreator kindly merge my PR. |
@AyushmanSinghRajawat update your branch and remove the changes you made to package.lock |
|
@AceTheCreator I have updated this branch and also removed changes from package-lock. You can merge my PR now. |
fixes #217
hey, @asyncapi-bot I have modified the subscription button by using the existing Button component so it will have same styling like other buttons in the app and i have also provided relevant top margin.
I had also updated caniuse-lite to it's latest version as otherwise it was not working.
I am new to open source and I enjoyed working on this issue, hope you like my solution.
Please let me know your thoughts and suggestions.