-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: made prospectus downloadable #330
feat: made prospectus downloadable #330
Conversation
✅ Deploy Preview for peaceful-ramanujan-288045 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mind adding a download icon in the button to make users know that it's a download button?
Sure I can! |
In my opinion one of these should be fine https://react-icons.github.io/react-icons/search/#q=download |
Hmmm... do we really have to install an icon library? |
You can just do it the way it's been done already |
No I mean just suggest a icon from that page I will implement the way we do it 😅 |
Hey @AceTheCreator or @thulieblack , could you suggest something over this? |
Not sure what @AceTheCreator meant by the download icon. Maybe specify on the Button text that -Download Sponsorship Prospectus |
He meant the same thing, just instead of |
Yeah thats exactly what we where thinking, 😅 . Just the doubt was whay icon will go properly with the theme. Hence I suggested using https://react-icons.github.io/react-icons/search/#q=download |
lets try that and see how it;ll look |
…it-coder/conference-website into feat/add-sponsor-prospectus
@thulieblack @Mayaleeeee Please take a look at this PR. Thanks! 👋 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Related issue(s)
Resolves: #329