Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional references between objects #185

Open
jeffywu opened this issue Feb 12, 2022 · 1 comment
Open

Add additional references between objects #185

jeffywu opened this issue Feb 12, 2022 · 1 comment
Assignees

Comments

@jeffywu
Copy link

jeffywu commented Feb 12, 2022

PoolSnapshot could be added as a derived reference on the Pool object, this would make it easy to get all the snapshots in context.

JoinExit and Swap objects could refer to PoolHistoricalLiquidity objects so that trade sizes relative to the pool could be calculated.

@mendesfabio
Copy link
Member

mendesfabio commented Dec 11, 2023

@thetroyharris you can also add: 1. JoinExit as derived reference to Pool, 2. blockNumber to JoinExit and Swap entity; 3. BalancerSnapshot as derived reference to Balancer

@thetroyharris thetroyharris mentioned this issue Dec 12, 2023
17 tasks
mendesfabio added a commit that referenced this issue Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants