Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap concepts section #14

Closed
johngrantuk opened this issue Mar 11, 2024 · 3 comments
Closed

Swap concepts section #14

johngrantuk opened this issue Mar 11, 2024 · 3 comments

Comments

@johngrantuk
Copy link
Member

Going deeper into single and multi-path swaps and what the configurations could look like. Similar to V2. Probably not in Guide but in some section that discusses more detailed aspects of Router/Vault.
We can then link to this on Swaps guide.

@mkflow27
Copy link
Collaborator

HI @johngrantuk Before release of V3 I wanted to also publish a #19 "anatomy of a batch-swap" page. This page would go into what happens in the Router/Vault/Pool during a batch-swap.

It would not go into

  • slippage calculations
  • Other languages being used to make a batch swap.

I was wondering if you think this issue could be combined with the "anatomy of a batchswap"?

@johngrantuk
Copy link
Member Author

HI @johngrantuk Before release of V3 I wanted to also publish a #19 "anatomy of a batch-swap" page. This page would go into what happens in the Router/Vault/Pool during a batch-swap.

It would not go into

* slippage calculations

* Other languages being used to make a batch swap.

I was wondering if you think this issue could be combined with the "anatomy of a batchswap"?

Yeah that was exactly what I was thinking. So if you already have an issue open for that we can close this one.

@johngrantuk
Copy link
Member Author

Closing as covered in #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants