Repository navigation
fix(integrations): run the bm and uv that PATH names in Hermes - #2110
Merged
Merged
Conversation
The Hermes provider tried ~/.local/bin, /opt/homebrew/bin and /usr/local/bin before PATH, so a stale uv-tool bm shadowed the one the user's shell runs. Search PATH first and keep the fixed locations as the fallback for launchd-style minimal PATHs. Fixes #1783 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CMYVL1rjJwNnrvxniz1dDD Signed-off-by: phernandez <paul@basicmachines.co>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1783.
#1783 reported two problems in the Hermes provider.
XDG_CONFIG_HOME. Already fixed under Hermes provider rejects Basic Memory 1.0 projects absent from legacy config.json registry #2019. The provider no longer reads Basic Memory's config file; it lists projects throughbm_project_liston thebm mcpchild, which resolves its own config directory._bm_binary_path()and_uv_binary_path()tried~/.local/bin,/opt/homebrew/binand/usr/local/binbefore PATH. A stale uv-toolbmin~/.local/bintherefore ran instead of thebmthe user's shell runs. This PR fixes that.Change
One
_find_binary(name, search_path=None)helper serves both lookups. It searches PATH first and falls back to the fixed locations only when PATH has no match. The fallback is still needed for a gateway under launchd, whose PATH is the minimal system default.Tests
test_find_binary_prefers_the_path_match: abmon the given PATH is returned even though~/.local/bin/bmmay exist.test_find_binary_skips_a_non_executable_path_entry: a non-executable file on PATH is not returned.just package-check-hermespasses (367 passed).🤖 Generated with Claude Code
https://claude.ai/code/session_01CMYVL1rjJwNnrvxniz1dDD