Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typing to avoid parameter redundancy #172

Open
github-actions bot opened this issue Jan 2, 2025 · 0 comments
Open

Fix typing to avoid parameter redundancy #172

github-actions bot opened this issue Jan 2, 2025 · 0 comments
Assignees
Labels
msar packages/myschoolapp-reporting snapshot msar snapshot types TypeScript type definition improvement

Comments

@github-actions
Copy link

github-actions bot commented Jan 2, 2025

// TODO Fix typing to avoid parameter redundancy

    await getPossibleContent();
    const topics = await api.datadirect.sectiontopicsget({
      payload: {
        // TODO Fix typing to avoid parameter redundancy
        active: true,
        future: true,
        expired: true,
        ...payload,
        format: 'json', // TODO Empirically, `format` is often optional
        sharedTopics: true // TODO sharedTopics should be configurable
      },
      pathParams: { Id }
    });
@battis battis added msar packages/myschoolapp-reporting snapshot msar snapshot types TypeScript type definition improvement labels Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
msar packages/myschoolapp-reporting snapshot msar snapshot types TypeScript type definition improvement
Projects
None yet
Development

No branches or pull requests

1 participant