Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement Multi-Objective / Goal system #34

Open
Tracked by #31
fabioseel opened this issue Oct 22, 2024 · 1 comment
Open
Tracked by #31

implement Multi-Objective / Goal system #34

fabioseel opened this issue Oct 22, 2024 · 1 comment
Labels
Feature A new capability in the library Major A large issue that may require a signficant commit

Comments

@fabioseel
Copy link
Contributor

fabioseel commented Oct 22, 2024

This is probably the biggest TODO.
I think there won't be a way around modifying the library to our needs, I am unsure whether weird side-effects could arise. Might be worth implementing some safety checks / tests first and approach this test-driven.

Definitely will affect the Learner class / backward step.

@fabioseel fabioseel mentioned this issue Oct 22, 2024
10 tasks
@fabioseel fabioseel added Feature A new capability in the library Major A large issue that may require a signficant commit labels Oct 22, 2024
@fabioseel fabioseel added this to the Sample Factory + RL milestone Oct 25, 2024
@fabioseel
Copy link
Contributor Author

fabioseel commented Nov 18, 2024

  • Check whether implementing an own Learner would be sufficient
    • potentially could allow to use completely custom model
      • yes and no. Actor critic is used in several other places, but its not completely outrageous...
      • more importantly: the RNN handling might be sth we want, so it might be worth keeping it
    • potentially could allow better initialization than write etc
      • seems hard without changing major parts of sample-factory
  • if so, find way to inject it or if we have to use our own cloned repo
    • with our own repo, we'd at least only have to maintain the Learner and can just rebase on the 'true' repo every now and then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature A new capability in the library Major A large issue that may require a signficant commit
Projects
None yet
Development

No branches or pull requests

1 participant