Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A default for GTEx run_PEER.R doesn't match the PEER library default #80

Open
kshakir opened this issue Sep 30, 2022 · 0 comments
Open

Comments

@kshakir
Copy link

kshakir commented Sep 30, 2022

The underlying PEER library uses a default alpha_pb of 0.1:

https://github.com/PMBio/peer/blob/40bc4b2cd92459ce42f44dfe279717436395f3f6/src/vbfa.cpp#L279-L282

Meanwhile the wrapper run_PEER.R uses a different default alphaprior_b of 0.01:

p <- add_argument(p, "--alphaprior_a", help="", default=0.001)
p <- add_argument(p, "--alphaprior_b", help="", default=0.01)
p <- add_argument(p, "--epsprior_a", help="", default=0.1)
p <- add_argument(p, "--epsprior_b", help="", default=10)

Is this intentional? We noticed the difference while switching our pipeline over to the GTEx provided Dockerfile. We don't usually set these values, but we can reproduce our existing pipeline outputs by explicitly setting the CLI parameter back to 0.1.

Thanks for sharing so many wonderfully packaged tools!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant