From 51668bacbd50751ba59ab7da2787fd9de55f2198 Mon Sep 17 00:00:00 2001
From: Lucas Gass <lucas@bywatersolutions.com>
Date: Thu, 12 Dec 2024 19:15:05 +0000
Subject: [PATCH] Start with cud- fixes

---
 .../MarywoodUniversity/RoomReservations.pm    | 42 ++++++------
 .../RoomReservations/configure.tt             | 68 +++++++++----------
 .../RoomReservations/tool.tt                  |  6 +-
 3 files changed, 58 insertions(+), 58 deletions(-)

diff --git a/Koha/Plugin/Com/MarywoodUniversity/RoomReservations.pm b/Koha/Plugin/Com/MarywoodUniversity/RoomReservations.pm
index 6184cb0..c72bb1c 100644
--- a/Koha/Plugin/Com/MarywoodUniversity/RoomReservations.pm
+++ b/Koha/Plugin/Com/MarywoodUniversity/RoomReservations.pm
@@ -475,7 +475,7 @@ sub tool {
     my $submit_partial_blackout =
       $cgi->param('submit-partial-blackout') || q{};  # add partial-day blackout
 
-    if (   $op eq 'action-selected'
+    if (   $op eq 'cud-action-selected'
         && $tool_action eq 'action-manage-reservations' )
     {
 
@@ -486,7 +486,7 @@ sub tool {
             bookings => $bookings,
         );
     }
-    elsif ($op eq 'action-selected'
+    elsif ($op eq 'cud-action-selected'
         && $tool_action eq 'action-manage-blackouts' )
     {
 
@@ -657,7 +657,7 @@ sub configure {
 
         );
     }
-    elsif ( $op eq 'action-selected' ) {
+    elsif ( $op eq 'cud-action-selected' ) {
 
         my $selected = $cgi->param('config_actions_selection');
 
@@ -665,7 +665,7 @@ sub configure {
 
         if ( $selected eq 'action-select-display' ) {
 
-            $action = 'display-rooms';
+            $action = 'cud-display-rooms';
 
             $template->param(
                 action => $action,
@@ -674,7 +674,7 @@ sub configure {
         }
         elsif ( $selected eq 'action-select-add' ) {
 
-            $action = 'add-rooms';
+            $action = 'cud-add-rooms';
 
             $template->param(
                 action => $action,
@@ -683,7 +683,7 @@ sub configure {
         }
         elsif ( $selected eq 'action-select-edit' ) {
 
-            $action = 'edit-rooms';
+            $action = 'cud-edit-rooms';
 
             $template->param(
                 action => $action,
@@ -692,7 +692,7 @@ sub configure {
         }
         elsif ( $selected eq 'action-select-delete' ) {
 
-            $action = 'delete-rooms';
+            $action = 'cud-delete-rooms';
 
             $template->param(
                 action => $action,
@@ -701,7 +701,7 @@ sub configure {
         }
         elsif ( $selected eq 'action-select-add-equipment' ) {
 
-            $action = 'add-equipment';
+            $action = 'cud-add-equipment';
 
             $template->param(
                 action => $action,
@@ -710,7 +710,7 @@ sub configure {
         }
         elsif ( $selected eq 'action-select-delete-equipment' ) {
 
-            $action = 'delete-equipment';
+            $action = 'cud-delete-equipment';
 
             $template->param(
                 action => $action,
@@ -719,7 +719,7 @@ sub configure {
         }
         elsif ( $selected eq 'action-max-future-date' ) {
 
-            $action = 'max-future-date';
+            $action = 'cud-max-future-date';
 
             $template->param(
                 action => $action,
@@ -728,7 +728,7 @@ sub configure {
         }
         elsif ( $selected eq 'action-max-time' ) {
 
-            $action = 'max-time';
+            $action = 'cud-max-time';
 
             $template->param(
                 action => $action,
@@ -829,7 +829,7 @@ sub configure {
             restrict_message      => $restricted_message,
         );
     }
-    elsif ( $op eq 'max-time' ) {
+    elsif ( $op eq 'cud-max-time' ) {
 
         my $submitted = $cgi->param('max-submitted') || q{};
 
@@ -855,7 +855,7 @@ sub configure {
 
         );
     }
-    elsif ( $op eq 'max-future-date' ) {
+    elsif ( $op eq 'cud-max-future-date' ) {
 
         my $submitted = $cgi->param('max-submitted') || q{};
 
@@ -878,7 +878,7 @@ sub configure {
 
         );
     }
-    elsif ( $op eq 'display-rooms' ) {
+    elsif ( $op eq 'cud-display-rooms' ) {
 
         my $roomnumbers = getAllRoomNumbers();
 
@@ -887,7 +887,7 @@ sub configure {
             roomnumbers => $roomnumbers,
         );
     }
-    elsif ( $op eq 'display-rooms-detail' ) {
+    elsif ( $op eq 'cud-display-rooms-detail' ) {
 
         my $roomIdToDisplay = $cgi->param('selected-displayed-room');
 
@@ -901,7 +901,7 @@ sub configure {
             selected_room_equipment => $roomEquipment,
         );
     }
-    elsif ( $op eq 'add-rooms' ) {
+    elsif ( $op eq 'cud-add-rooms' ) {
 
         my $addedRoom = $cgi->param('added-room') || q{};
 
@@ -923,7 +923,7 @@ sub configure {
             all_room_numbers    => $roomNumbers,
         );
     }
-    elsif ( $op eq 'edit-rooms' ) {
+    elsif ( $op eq 'cud-edit-rooms' ) {
 
         my $editing              = $cgi->param('editing')                || q{};
         my $roomDetailsUpdated   = $cgi->param('room-details-updated')   || q{};
@@ -958,7 +958,7 @@ sub configure {
             current_rooms => $roomNumbers,
         );
     }
-    elsif ( $op eq 'edit-rooms-selection' ) {
+    elsif ( $op eq 'cud-edit-rooms-selection' ) {
 
         my $choice = $cgi->param('edit-rooms-choice') || q{};
 
@@ -1007,7 +1007,7 @@ sub configure {
             all_available_equipment => $allAvailableEquipment,
         );
     }
-    elsif ( $op eq 'delete-rooms' ) {
+    elsif ( $op eq 'cud-delete-rooms' ) {
 
         my $delete = $cgi->param('delete') || q{};
 
@@ -1035,7 +1035,7 @@ sub configure {
             rooms_available_to_delete => 1,
         );
     }
-    elsif ( $op eq 'add-equipment' ) {
+    elsif ( $op eq 'cud-add-equipment' ) {
 
         my $insert = $cgi->param('insert') || q{};
 
@@ -1058,7 +1058,7 @@ sub configure {
             available_equipment => $availableEquipment,
         );
     }
-    elsif ( $op eq 'delete-equipment' ) {
+    elsif ( $op eq 'cud-delete-equipment' ) {
 
         my $delete = $cgi->param('delete') || q{};
 
diff --git a/Koha/Plugin/Com/MarywoodUniversity/RoomReservations/configure.tt b/Koha/Plugin/Com/MarywoodUniversity/RoomReservations/configure.tt
index 4867fe8..f117974 100644
--- a/Koha/Plugin/Com/MarywoodUniversity/RoomReservations/configure.tt
+++ b/Koha/Plugin/Com/MarywoodUniversity/RoomReservations/configure.tt
@@ -85,7 +85,7 @@
         [% INCLUDE 'csrf-token.inc' %]
         <input type="hidden" name="class" value="[% CLASS %]" />
         <input type="hidden" name="method" value="[% METHOD %]" />
-        <input type="hidden" name="op" value="action-selected" />
+        <input type="hidden" name="op" value="cud-action-selected" />
 
         <fieldset class="fieldset-auto-width">
             <legend>[% 'Actions' | gettext %]</legend>
@@ -110,7 +110,7 @@
     </form>
     [% END # op == '' %]
 
-    [% IF op == 'action-selected' %]
+    [% IF op == 'cud-action-selected' %]
     <script type="text/javascript">
         // binds onload to anonymous function
         // this causes the fieldless form below
@@ -131,9 +131,9 @@
             <input type="submit" name="actionSelectedBtn" id="actionSelectedBtn" />
         </div>
     </form>
-    [% END # op == 'action-selected' %]
+    [% END # op == 'cud-action-selected' %]
 
-    [% IF op == 'display-rooms' %]
+    [% IF op == 'cud-display-rooms' %]
     <script type="text/javascript">
             function validateDisplayRooms() {
                 // populate an equipment array to iterate for validation
@@ -166,7 +166,7 @@
         [% INCLUDE 'csrf-token.inc' %]
         <input type="hidden" name="class" value="[% CLASS %]" />
         <input type="hidden" name="method" value="[% METHOD %]" />
-        <input type="hidden" name="op" value="display-rooms-detail" />
+        <input type="hidden" name="op" value="cud-display-rooms-detail" />
         <table>
         <thead>
             <tr>
@@ -198,9 +198,9 @@
         </tfoot>
         </table>
     </form>
-    [% END # op == 'display-rooms' %]
+    [% END # op == 'cud-display-rooms' %]
 
-    [% IF op == 'display-rooms-detail' %]
+    [% IF op == 'cud-display-rooms-detail' %]
     <form method="post" action="#">
         [% INCLUDE 'csrf-token.inc' %]
         <input type="hidden" name="class" value="[% CLASS %]" />
@@ -214,7 +214,7 @@
         [% INCLUDE 'csrf-token.inc' %]
         <input type="hidden" name="class" value="[% CLASS %]" />
         <input type="hidden" name="method" value="[% METHOD %]" />
-        <input type="hidden" name="op" value="display-rooms" />
+        <input type="hidden" name="op" value="cud-display-rooms" />
 
         <button>[% 'Select another room to display' | gettext %]</button>
     </form>
@@ -245,9 +245,9 @@
             [% END # FOREACH room IN selected_room_details %]
         </tbody>
     </table>
-    [% END # op == 'display-rooms-detail' %]
+    [% END # op == 'cud-display-rooms-detail' %]
 
-    [% IF op == 'max-future-date' %]
+    [% IF op == 'cud-max-future-date' %]
         <form method="post" action="#">
             [% INCLUDE 'csrf-token.inc' %]
             <input type="hidden" name="class" value="[% CLASS %]" />
@@ -278,7 +278,7 @@
             [% INCLUDE 'csrf-token.inc' %]
             <input type="hidden" name="class" value="[% CLASS %]" />
             <input type="hidden" name="method" value="[% METHOD %]" />
-            <input type="hidden" name="op" value="max-future-date" />
+            <input type="hidden" name="op" value="cud-max-future-date" />
             <input type="hidden" name="max-submitted" value="1" />
             <table>
                 <thead class="table-header-bold table-row-centered">
@@ -310,7 +310,7 @@
                 </tfoot>
             </table>
         </form>
-    [% END # op == 'max-future-date' %]
+    [% END # op == 'cud-max-future-date' %]
 
     [% IF op == 'max-time' %]
         <form method="post" action="#">
@@ -577,7 +577,7 @@
         </form>
     [% END # op == 'restrict-categories' %]
 
-    [% IF op == 'add-rooms' %]
+    [% IF op == 'cud-add-rooms' %]
         <script type="text/javascript">
             function validateAddRooms() {
                 var roomname = document.forms["addRoomForm"]["add-room-roomnumber"].value;
@@ -639,7 +639,7 @@
             [% INCLUDE 'csrf-token.inc' %]
             <input type="hidden" name="class" value="[% CLASS %]" />
             <input type="hidden" name="method" value="[% METHOD %]" />
-            <input type="hidden" name="op" value="add-rooms" />
+            <input type="hidden" name="op" value="cud-add-rooms" />
             <input type="hidden" name="added-room" value="1" />
             <table>
                 <thead class="table-header-bold table-row-centered">
@@ -682,9 +682,9 @@
                 </tfoot>
             </table>
         </form>
-    [% END # op == 'add-rooms' %]
+    [% END # op == 'cud-add-rooms' %]
 
-    [% IF op == 'edit-rooms' %]
+    [% IF op == 'cud-edit-rooms' %]
         <script type="text/javascript">
             function validateEditRooms() {
                 var editChoice = document.forms["editRoomsForm"]["edit-rooms-choice"].value;
@@ -709,7 +709,7 @@
             [% INCLUDE 'csrf-token.inc' %]
             <input type="hidden" name="class" value="[% CLASS %]" />
             <input type="hidden" name="method" value="[% METHOD %]" />
-            <input type="hidden" name="op" value="edit-rooms-selection" />
+            <input type="hidden" name="op" value="cud-edit-rooms-selection" />
             <input type="hidden" name="editing" value="1" />
             <table>
                 <thead>
@@ -741,9 +741,9 @@
                 </tfoot>
             </table>
         </form>
-    [% END # op == 'edit-rooms' %]
+    [% END # op == 'cud-edit-rooms' %]
 
-    [% IF op == 'edit-rooms-selection' %]
+    [% IF op == 'cud-edit-rooms-selection' %]
     <script type="text/javascript">
         // binds onload to anonymous function
         // this causes the fieldless form below
@@ -765,7 +765,7 @@
             <input type="submit" name="actionSelectedBtn" id="actionSelectedBtn" />
         </div>
     </form>
-    [% END # IF op == 'edit-rooms-selection' %]
+    [% END # IF op == 'cud-edit-rooms-selection' %]
 
     [% IF op == 'edit-rooms-room' %]
         <script type="text/javascript">
@@ -797,7 +797,7 @@
             [% INCLUDE 'csrf-token.inc' %]
             <input type="hidden" name="class" value="[% CLASS %]" />
             <input type="hidden" name="method" value="[% METHOD %]" />
-            <input type="hidden" name="op" value="edit-rooms" />
+            <input type="hidden" name="op" value="cud-edit-rooms" />
 
             <button>[% 'Select another room to edit' | gettext %]</button>
         </form>
@@ -807,7 +807,7 @@
             [% INCLUDE 'csrf-token.inc' %]
             <input type="hidden" name="class" value="[% CLASS %]" />
             <input type="hidden" name="method" value="[% METHOD %]" />
-            <input type="hidden" name="op" value="edit-rooms" />
+            <input type="hidden" name="op" value="cud-edit-rooms" />
             <input type="hidden" name="room-details-updated" value="1" />
             <table>
                 <thead>
@@ -833,7 +833,7 @@
                 </tfoot>
             </table>
         </form>
-    [% END # IF op == 'edit-rooms-room' %]
+    [% END # IF op == 'cud-edit-rooms-room' %]
 
     [% IF op == 'edit-rooms-equipment' %]
         <script type="text/javascript">
@@ -866,7 +866,7 @@
             [% INCLUDE 'csrf-token.inc' %]
             <input type="hidden" name="class" value="[% CLASS %]" />
             <input type="hidden" name="method" value="[% METHOD %]" />
-            <input type="hidden" name="op" value="edit-rooms" />
+            <input type="hidden" name="op" value="cud-edit-rooms" />
 
             <button>[% 'Select another room to edit' | gettext %]</button>
         </form>
@@ -876,7 +876,7 @@
             [% INCLUDE 'csrf-token.inc' %]
             <input type="hidden" name="class" value="[% CLASS %]" />
             <input type="hidden" name="method" value="[% METHOD %]" />
-            <input type="hidden" name="op" value="edit-rooms" />
+            <input type="hidden" name="op" value="cud-edit-rooms" />
             <input type="hidden" name="room-equipment-updated" value="1" />
             <table>
                 <thead>
@@ -912,9 +912,9 @@
                 </tfoot>
             </table>
         </form>
-    [% END # IF op == 'edit-rooms-equipment' %]
+    [% END # IF op == 'cud-edit-rooms-equipment' %]
 
-    [% IF op == 'delete-rooms' %]
+    [% IF op == 'cud-delete-rooms' %]
     <script type="text/javascript">
             function deleteRoomConfirmation() {
                 var rooms = document.getElementsByName("delete-room-radio-button");
@@ -957,7 +957,7 @@
         [% IF rooms_available_to_delete == 1 %]
         <input type="hidden" name="class" value="[% CLASS %]" />
         <input type="hidden" name="method" value="[% METHOD %]" />
-        <input type="hidden" name="op" value="delete-rooms" />
+        <input type="hidden" name="op" value="cud-delete-rooms" />
         <input type="hidden" name="delete" value="1" />
         <table>
             <thead>
@@ -986,9 +986,9 @@
     <h2>[% 'No rooms available to delete!' | gettext %]</h2>
     [% END %]
     </form>
-    [% END # op == 'delete-rooms' %]
+    [% END # op == 'cud-delete-rooms' %]
 
-    [% IF op == 'add-equipment' %]
+    [% IF op == 'cud-add-equipment' %]
     <script type="text/javascript">
             function validateAddEquipment() {
                 var equipmentname = document.forms["addEquipment"]["add-equipment-text-field"].value;
@@ -1033,7 +1033,7 @@
         [% INCLUDE 'csrf-token.inc' %]
         <input type="hidden" name="class" value="[% CLASS %]" />
         <input type="hidden" name="method" value="[% METHOD %]" />
-        <input type="hidden" name="op" value="add-equipment" />
+        <input type="hidden" name="op" value="cud-add-equipment" />
         <input type="hidden" name="insert" value="1" />
         <table>
             <thead class="table-header-bold table-row-centered">
@@ -1051,9 +1051,9 @@
             </tbody>
         </table>
     </form>
-    [% END # op == 'add-equipment' %]
+    [% END # op == 'cud-add-equipment' %]
 
-    [% IF op == 'delete-equipment' %]
+    [% IF op == 'cud-delete-equipment' %]
     <script type="text/javascript">
             function deleteEquipmentConfirmation() {
                 var equipment = document.getElementsByName("delete-equipment-radio-button");
@@ -1095,7 +1095,7 @@
         [% INCLUDE 'csrf-token.inc' %]
         <input type="hidden" name="class" value="[% CLASS %]" />
         <input type="hidden" name="method" value="[% METHOD %]" />
-        <input type="hidden" name="op" value="delete-equipment" />
+        <input type="hidden" name="op" value="cud-delete-equipment" />
         <input type="hidden" name="delete" value="1" />
         <table>
             <thead>
diff --git a/Koha/Plugin/Com/MarywoodUniversity/RoomReservations/tool.tt b/Koha/Plugin/Com/MarywoodUniversity/RoomReservations/tool.tt
index 6e7ef42..a92f4a6 100644
--- a/Koha/Plugin/Com/MarywoodUniversity/RoomReservations/tool.tt
+++ b/Koha/Plugin/Com/MarywoodUniversity/RoomReservations/tool.tt
@@ -56,7 +56,7 @@
         [% INCLUDE 'csrf-token.inc' %]
     	<input type="hidden" name="class" value="[% CLASS %]" />
         <input type="hidden" name="method" value="[% METHOD %]" />
-        <input type="hidden" name="op" value="action-selected" />
+        <input type="hidden" name="op" value="cud-action-selected" />
 
         <fieldset class="fieldset-auto-width">
         	<legend>[% 'Actions' | gettext %]</legend>
@@ -73,7 +73,7 @@
     </form>
     [% END # op == '' %]
 
-    [% IF op == 'action-selected' %]
+    [% IF op == 'cud-action-selected' %]
     <script type="text/javascript">
         // binds onload to anonymous function
         // this causes the fieldless form below
@@ -94,7 +94,7 @@
             <input type="submit" name="actionSelectedBtn" id="actionSelectedBtn" />
         </div>
     </form>
-    [% END # op == 'action-selected' %]
+    [% END # op == 'cud-action-selected' %]
 
     [% IF op == 'manage-reservations' %]
     <script type="text/javascript">