Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cancer type summary shows sample counts in tooltip rather than cases #11311

Open
inodb opened this issue Jan 1, 2025 · 3 comments
Open

cancer type summary shows sample counts in tooltip rather than cases #11311

inodb opened this issue Jan 1, 2025 · 3 comments
Labels

Comments

@inodb
Copy link
Member

inodb commented Jan 1, 2025

Query BRAF V600E in Thyroid cases of msk_impact_2017:

image

It mentions cases in the tooltip, but these are sample counts. In the downloads tab, if you create a virtual study of the altered samples one can see that it's 84 samples and 81 patients/cases:

image image

Sidenote

Stumbled upon this while testing a new CLI tool I've been working on:

> cbiohub variant-frequency V600E --group-by-study-id --count-samples | grep msk_impact_2017
msk_impact_2017                    Thyroid Cancer                                84      231    36.4
> cbiohub variant-frequency BRAF V600E --group-by-study-id | grep msk_impact_2017
msk_impact_2017                    Thyroid Cancer                                81      226    35.8

Please find duckdb_query.txt as well to reproduce the result

@inodb inodb added the bug label Jan 1, 2025
@FilledEther20
Copy link

Greetings @inodb,
I’d like to work on this issue if it’s available. Could you please assign it to me?
Thanks!

@anshuman-rai-27
Copy link

@inodb so here we just need to sync cases in summary and in that table , like example above 84 cases sholud change to 231 cases ? is it what required here ?

@inodb
Copy link
Member Author

inodb commented Jan 2, 2025

@anshuman-rai-27 Thansk for checking! Ideally we can add a UI toggle to indicate whether a user wants sample or patient counts. Then show counts accordingly (81/226 when counting patients, or 84/231 when counting samples)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants