Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update e2e tests to use CANCER_TYPE rather than tumor type #11321

Open
inodb opened this issue Jan 2, 2025 · 3 comments · May be fixed by cBioPortal/cbioportal-frontend#5077
Open

Update e2e tests to use CANCER_TYPE rather than tumor type #11321

inodb opened this issue Jan 2, 2025 · 3 comments · May be fixed by cBioPortal/cbioportal-frontend#5077

Comments

@inodb
Copy link
Member

inodb commented Jan 2, 2025

There are several end-to-end tests that color scatter plots based on tumor type:

  • plots_tab_scatter_plot_color_by_tumor_type
  • plots_tab_scatter_plot_color_by_tumor_type_highlight_categories
  • plots_tab_box_plot_color_by_tumor_type
  • plots_tab_box_plot_color_by_tumor_type_highlight_categories
  • plots_tab_waterfall_plot_color_by_tumor_type
  • plots_tab_waterfall_plot_color_by_tumor_type_highlight_categories

See e.g. plots_tab_box_plot_color_by_tumor_type_highlight_categories:

image
From: https://output.circle-artifacts.com/output/job/95bd19f2-0b4e-4cc5-beab-bb20a9ec0996/artifacts/0/imageCompare.html

These don't have defined colors so the colors can change randomly. The CANCER_TYPE attribute has hardcoded colors, see e.g. AML:

image
from https://oncotree.info

Let's use that instead for testing

@Swayam-code
Copy link

Hey @inodb , I can take this on. I’ll update the end-to-end tests for scatter plots, box plots, and waterfall plots to use the hardcoded CANCER_TYPE attribute colors (e.g., from OncoTree, like AML's LightSalmon). This will ensure consistent and predictable color mapping across tests, avoiding random color changes. I'll ensure the updates are comprehensive and tested.

I'll be grateful, if you could assign this issue to me?

@inodb
Copy link
Member Author

inodb commented Jan 2, 2025

Thanks so much @Swayam-code ! We usually don't assign tickets outside of the core contributor team, so please go ahead. Nobody else is working on it

@rishisulakhe
Copy link

Glad to work on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants