Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArraySource find empty records #83

Open
ghost opened this issue Oct 11, 2013 · 1 comment
Open

ArraySource find empty records #83

ghost opened this issue Oct 11, 2013 · 1 comment
Labels

Comments

@ghost
Copy link

ghost commented Oct 11, 2013

Created by Gallagher, 30th Nov 2012. (originally Lighthouse ticket #45):


If you do a find on a model which uses ArraySource datasource and the Model::records property is empty, then the returned value is something like:
array(
'Model' => array()
)
Whereas I think the returned value should be:
array()
If you want I can fix this myself, add a test and create a pull request, but I am wondering is there a situation (maybe when the model is a related model) where it should return the value which it does or is it just plan incorrect.

@ghost
Copy link
Author

ghost commented Oct 11, 2013

30th Nov 2012, Gallagher said:


BTW, this is for the 2.0 branch.

@AD7six AD7six added the array label Feb 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant