Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IElementInternals missing recently added ariaDescription type field #128

Closed
nkabrown opened this issue Mar 15, 2024 · 1 comment · Fixed by #129
Closed

IElementInternals missing recently added ariaDescription type field #128

nkabrown opened this issue Mar 15, 2024 · 1 comment · Fixed by #129

Comments

@nkabrown
Copy link
Contributor

TypeScript recently added ariaDescription as a type field in its automatically generated DOM typings in this commit.

Updating to TypeScript 5.4+ throws error TS2741: Property 'ariaDescription' is missing in type 'ElementInternals & IElementInternals' but required in type 'ElementInternals'
@nkabrown nkabrown mentioned this issue Mar 15, 2024
Merged
@nkabrown
Copy link
Contributor Author

nkabrown commented Apr 9, 2024

The custom elements manifest analyzer has recently released patch version 0.9.4 that relies on TypeScript 5.4 making it harder for web component projects to stay on TypeScript 5.3. I've opened and tested PR #129 that I believe resolves this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add ariaDescription to interfaces nkabrown/element-internals-polyfill
1 participant
@nkabrown