tests: fix flaky snap test by adding multiple retries #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benhoyt
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One test,
test_snap_set_and_get_with_typed, often fails -- maybe 50% of the time. It fails when trying to ensure that thelxdsnap is present on the latest version, raising aSnapErrorwith the message 'Waiting for "snap.lxd.daemon.service" to stop'.The existing code catches this once, waits 60 seconds and retries. Since the test often passes, this must sometimes be sufficient, so this PR simply uses slightly more robust retry logic -- retrying up to 10 times with 20 seconds in between each attempt. In 5/5 CI runs, this passed every time .
As a future CI improvement, it would be nice to improve test turnaround time by using snaps at versions that are already installed in the runner images as much as possible.
Resolves #123
Resolves #133