Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we consolidate interface, scenario tests under unit? #1500

Open
sed-i opened this issue Dec 15, 2024 · 1 comment
Open

Should we consolidate interface, scenario tests under unit? #1500

sed-i opened this issue Dec 15, 2024 · 1 comment

Comments

@sed-i
Copy link
Contributor

sed-i commented Dec 15, 2024

Currently,

  • Some charming teams have both unit and scenario under tests.
  • Interface tester assumes tests are under tests/interface, so we have to have yet another folder under tests.

Since harness, scenario an interface tests (and the occasional doctests!) are all unit tests, would it make more sense to encourage hosting them all under tests/unit? This could also ease making coverage calculation more precise.

@benhoyt
Copy link
Collaborator

benhoyt commented Dec 15, 2024

Hey @sed-i, this makes sense to me. I notice the charmcraft init templates have only "unit" and "integration". We can't actually police this in canonical/operator. Are you thinking that we'd have some (maybe charmcraft) plugin to check for this, or just a "best practice" that we'd document/promote?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants