Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logo Section Comp with Links #5388

Open
mattea-turic opened this issue Oct 14, 2024 · 3 comments
Open

Logo Section Comp with Links #5388

mattea-turic opened this issue Oct 14, 2024 · 3 comments
Labels
P3 Needs decision Needs team agreement in terms of triaging. P3 Triaged Issue has been reviewed as part of legacy backlog grooming (project P3). WG: Validated Validate working group proposals

Comments

@mattea-turic
Copy link

Component/pattern to amend

Logo section

Visual

Provide a screenshot or link to a prototype of your pattern amendment.

Screenshot 2024-10-14 at 16 41 03

Context

Current comp handles logos but not when there are links associated with it. This has often been a fallback option, but doesn't follow the 12-col grid and so spacing looks inconsistent:
Screenshot 2024-10-14 at 16 46 32

The suggestion I'm putting forward adds links while following the typical layout, so should look neater.

@mattea-turic mattea-turic added the WG: Proposal Working group proposals label Oct 14, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/WD-15867.

This message was autogenerated

@bartaz
Copy link
Member

bartaz commented Oct 15, 2024

@lyubomir-popov Any thoughts? Is this a new variation of "Logo section" or something new?

Logo section was designed and built to be "inline", regardless of logo width, with wrapping, etc.

This new proposal is very much tied to the grid. Also, looks like something that could be achieved with image containers, and possibly equal heights row?

@bartaz bartaz added the Vanilla WG Task owned by Vanilla Working Group label Oct 16, 2024
@danielmutis
Copy link

WG: this component should go through the HOC process to gather requirements.

@bartaz bartaz added WG: Validated Validate working group proposals P3 Triaged Issue has been reviewed as part of legacy backlog grooming (project P3). P3 Needs decision Needs team agreement in terms of triaging. and removed WG: Proposal Working group proposals Vanilla WG Task owned by Vanilla Working Group labels Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Needs decision Needs team agreement in terms of triaging. P3 Triaged Issue has been reviewed as part of legacy backlog grooming (project P3). WG: Validated Validate working group proposals
Projects
None yet
Development

No branches or pull requests

3 participants