Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hero Pattern: Incorrect section placement #5396

Open
jmuzina opened this issue Oct 23, 2024 · 2 comments
Open

Hero Pattern: Incorrect section placement #5396

jmuzina opened this issue Oct 23, 2024 · 2 comments

Comments

@jmuzina
Copy link
Member

jmuzina commented Oct 23, 2024

Describe the bug

While building canonical/canonical.com#1406, I noticed an issue with the hero macro that prevented the page from being built with the hero macro. When flipping between my in-progress support page and the postgresql managed page, I found that the spacing between the title and the description was different.

Currently, the title blocks are wrapped in .p-section--shallow, and the description is wrapped in a separate .p-section--shallow. This creates a lot of space between the title area and the description:

Screenshot 2024-10-23 at 3 11 07 PM

Following the example from the postgresql managed page, the titles and description can all be wrapped in a single shallow section to tighten things up a bit:

Screenshot 2024-10-23 at 3 12 54 PM
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/WD-16099.

This message was autogenerated

@jmuzina
Copy link
Member Author

jmuzina commented Oct 29, 2024

It's not quite as simple as just changing to wrapping both in a shallow section, as the heading and subheading are not always in the same container. The full-width image version splits these across two separate columns. We should make sure that the correct element has shallow section spacing in that case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant