Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle Plugin V3 #103

Closed
2 of 4 tasks
augustearth opened this issue Nov 15, 2022 · 2 comments
Closed
2 of 4 tasks

Gradle Plugin V3 #103

augustearth opened this issue Nov 15, 2022 · 2 comments
Assignees

Comments

@augustearth
Copy link
Collaborator

augustearth commented Nov 15, 2022

The Gradle plugin carnival-grade is mostly obsolete in V3. The only part that might still be useful is the addition of dependencies that is done by CarnivalLibraryPlugin. CarnivalApplicationPlugin can probably be removed entirely. CarnivalLibraryPlugin can be renamed to CarnivalPlugin and just do the dependency stuff.

Related to the plugin are the references to carnival.home in the code. They are mostly gone, but should be removed entirely.

Similarly, references to logback.configurationFile in the top level build.gradle should also be reconsidered. They should probably stay, but should be reviewed.

Tasks

  • Move logback.configurationFile stuff from CarnivalApplicationPlugin.groovy to the demo app build.gradle
  • Remove CarnivalApplicationPlugin.groovy #121
  • Rename CarnivalLibraryPlugin to CarnivalPlugin
  • Remove all mentions of carnival.home
@augustearth augustearth self-assigned this Nov 15, 2022
@augustearth
Copy link
Collaborator Author

logback.configurationFile

  • is passed through to sub-project test tasks in build.gradle
  • in CarnivalApplicationPlugin, file is sought in the app home directory. if found, passed to project.run and project.test environments

What's happening in build.gradle makes sense.... We want the log settings to propagate when running Carnival tests.

What's happening in the Carnival application plugin can be done by client application code. We should add something to the demonstration app to show how it could work with Micronaut apps.

augustearth added a commit that referenced this issue Nov 18, 2022
@augustearth
Copy link
Collaborator Author

This is done. CarnivalLibraryPlugin and CarnivalApplicationPlugin both still exist, but only CarnivalLibraryPlugin is used to create the plugin which is now just called 'carnival'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant