Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to catalogue record fetching #124

Open
watucker opened this issue Sep 22, 2023 · 1 comment
Open

Improvements to catalogue record fetching #124

watucker opened this issue Sep 22, 2023 · 1 comment

Comments

@watucker
Copy link
Member

We might need a better way to handle not being able to fetch a catalogue record, and probably shouldn't need to try more than one API endpoint (the MOLES catalogue) to get a cachable result. See:

def moles_record(path):

Unsure what the best way to handle a failure is, but at least we should remove "catalogue.ceda.ac.uk" from the list of CAT_URLS.

@watucker
Copy link
Member Author

It's been noted that a relatively new addition to the "moles_record" function above may have caused some unexpected problems. Specifically, the code within this if block may need better error handling:

if data.get("record_type") == 'Dataset':

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant