Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NCAS RADAR v1 #41

Closed
3 tasks
joshua-hampton opened this issue Oct 13, 2023 · 2 comments
Closed
3 tasks

NCAS RADAR v1 #41

joshua-hampton opened this issue Oct 13, 2023 · 2 comments

Comments

@joshua-hampton
Copy link
Collaborator

Start of adding checks for the NCAS-RADAR standard. This standard is in some ways more relaxed than NCAS-GENERAL and NCAS-IMAGE. For example, there are a large number of variables permitted by CfRadial (and therefore NCAS-RADAR), but it is not expected that all of them would appear in one file. There are also looser restrictions around variable attributes, for example, the type of each variable is not defined, but stated to be "one of byte, short, integer, float, double", and _FillValue is "of the same type as the data variable".

What needs to be done:

  • spec file(s) that contain this information. A couple of ways to do this, either one spec file per variable, and checksit only uses ones related to variables in the file, or one spec file with all variables in, and rather than returning warnings or errors when variables aren't found in the file checksit ignores them because it knows its an NCAS-RADAR file (I think this second option would need some sort of attribute/variable carried through within checksit that states this file is NCAS-RADAR, the first option would require logic similar to that used for NCAS-GENERAL that identifies which specs are needed).
  • rule_attr paramter added to checksit.generic.check_var, to allow some variable attributes (e.g. type) to be checked against a rule
  • a new rule same-type-as, which takes one paramter which should be the name of a variable, and checks the value of the attribute (e.g. _FillValue) matches the type of the stated variable

I'm sure I'll find more as I go.

@joshua-hampton
Copy link
Collaborator Author

PR #48 address the needs of NCAS-Radar checks

@joshua-hampton
Copy link
Collaborator Author

PR merged, closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant