From 0f591d8acc1250e1b1028582a767f743c8c0f39d Mon Sep 17 00:00:00 2001
From: Cristian <92550620+TheyCallMeCris@users.noreply.github.com>
Date: Mon, 23 Oct 2023 00:14:42 -0400
Subject: [PATCH] feat(VIST-CPC-925): changing vet id and pet id to vet name
 and pet name in the visits-list page (#584)

JIRA: [link to jira
ticket](https://champlainsaintlambert.atlassian.net/browse/CPC-925)
## Context:
The list displayed many non user friendly data such as the vetId and
petId that are UUIDS. By displaying the vet's and pet's names instead of
their Id, our website becomes more user-friendly.
## Changes
Changed the front-end to display vet name and pet name instead of their
Ids
This can be bullet point or sentence format.

UI CHANGES

**BEFORE**

![image](https://github.com/cgerard321/champlain_petclinic/assets/92550620/c0bdef35-b61b-43a8-b55d-82c74a6bb2f9)

**AFTER**

![image](https://github.com/cgerard321/champlain_petclinic/assets/92550620/488f53d5-fef8-4c5d-853d-f708c93f00f1)
---
 .../visit-list/visit-list.template.html        | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/api-gateway/src/main/resources/static/scripts/visit-list/visit-list.template.html b/api-gateway/src/main/resources/static/scripts/visit-list/visit-list.template.html
index 7d3365b7e5..78b10b6f32 100644
--- a/api-gateway/src/main/resources/static/scripts/visit-list/visit-list.template.html
+++ b/api-gateway/src/main/resources/static/scripts/visit-list/visit-list.template.html
@@ -109,8 +109,8 @@ <h3 style="margin: 0; display: inline-block;">Upcoming Visits</h3>
         <td class="border">{{v.visitDate | date:'yyyy-MM-ddTHH:mm:ss'}}</td>
         <td class="border" style="white-space: pre-line">{{v.description}}</td>
         <!--        <td style="white-space: pre-line">{{$ctrl.getPractitionerName(v.practitionerId)}}</td>-->
-        <td class="border" style="white-space: pre-line">{{v.practitionerId}}</td>
-        <td class="border" style="white-space: pre-line">{{v.petId}}</td>
+        <td class="border" style="white-space: pre-line">{{v.vetFirstName}} {{v.vetLastName}}</td>
+        <td class="border" style="white-space: pre-line">{{v.petName}}</td>
         <td class="status-text" style="white-space: pre-line"></td>
         <td class="status-text border" style="white-space: pre-line">{{v.status}}</td>
         <td class="border">
@@ -170,8 +170,8 @@ <h3 style="margin: 0; display: inline-block;">Confirmed Visits</h3>
         <td class="border">{{v.visitDate | date:'yyyy-MM-ddTHH:mm:ss'}}</td>
         <td class="border" style="white-space: pre-line">{{v.description}}</td>
         <!--        <td style="white-space: pre-line">{{$ctrl.getPractitionerName(v.practitionerId)}}</td>-->
-        <td class="border" style="white-space: pre-line">{{v.practitionerId}}</td>
-        <td class="border" style="white-space: pre-line">{{v.petId}}</td>
+        <td class="border" style="white-space: pre-line">{{v.vetFirstName}} {{v.vetLastName}}</td>
+        <td class="border" style="white-space: pre-line">{{v.petName}}</td>
         <td class="status-text" style="white-space: pre-line"></td>
         <td class="status-text border" style="white-space: pre-line">{{v.status}}</td>
         <td class="border">
@@ -232,8 +232,8 @@ <h3 style="margin: 0; display: inline-block;">Cancelled Visits</h3>
         <td class="border">{{v.visitDate | date:'yyyy-MM-ddTHH:mm:ss'}}</td>
         <td class="border" style="white-space: pre-line">{{v.description}}</td>
         <!--        <td style="white-space: pre-line">{{$ctrl.getPractitionerName(v.practitionerId)}}</td>-->
-        <td class="border" style="white-space: pre-line">{{v.practitionerId}}</td>
-        <td class="border" style="white-space: pre-line">{{v.petId}}</td>
+        <td class="border" style="white-space: pre-line">{{v.vetFirstName}} {{v.vetLastName}}</td>
+        <td class="border" style="white-space: pre-line">{{v.petName}}</td>
         <td class="status-text" style="white-space: pre-line"></td>
         <td class="status-text border" style="white-space: pre-line">{{v.status}}</td>
         <td class="border">
@@ -293,8 +293,8 @@ <h3 style="margin: 0; display: inline-block;">Completed Visits</h3>
         <td class="border">{{v.visitDate | date:'yyyy-MM-ddTHH:mm:ss'}}</td>
         <td class="border" style="white-space: pre-line">{{v.description}}</td>
         <!--        <td style="white-space: pre-line">{{$ctrl.getPractitionerName(v.practitionerId)}}</td>-->
-        <td class="border" style="white-space: pre-line">{{v.practitionerId}}</td>
-        <td class="border" style="white-space: pre-line">{{v.petId}}</td>
+        <td class="border" style="white-space: pre-line">{{v.vetFirstName}} {{v.vetLastName}}</td>
+        <td class="border" style="white-space: pre-line">{{v.petName}}</td>
         <td class="status-text" style="white-space: pre-line"></td>
         <td class="status-text border" style="white-space: pre-line">{{v.status}}</td>
         <td class="border">
@@ -318,4 +318,4 @@ <h3 style="margin: 0; display: inline-block;">Completed Visits</h3>
         <td class="border"><a class="btn btn-danger" href="javascript:void(0)" ng-click="deleteVisit(v.visitId)">Delete Visit</a></td>
     </tr>
     </tbody>
-</table>
\ No newline at end of file
+</table>