Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

non-enumerable Symbol properties should not fail equality #1509

Open
gullerya opened this issue Feb 27, 2023 · 2 comments
Open

non-enumerable Symbol properties should not fail equality #1509

gullerya opened this issue Feb 27, 2023 · 2 comments
Labels
waiting-on-reporter Issues where we are waiting to hear back from the original reporter

Comments

@gullerya
Copy link

The 4.3.7 version added comparison of object properties keyed by Symbol, but elsewhere (deep-eql) it is already decided that only enumerable symbols, those that were deliberately designated to be so by the implementation, should be taken into consideration of the test.
Please release a version of chai that is not failing when deepEqual on non-enumerable Symbol properties.
@simlu
Copy link

simlu commented Jul 24, 2023

Would be great to hear feedback on this ticket

@koddsson
Copy link
Member

Hey @gullerya; can you add a minimal reproduction steps of the issue you are having?

@koddsson koddsson added the waiting-on-reporter Issues where we are waiting to hear back from the original reporter label Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
waiting-on-reporter Issues where we are waiting to hear back from the original reporter
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@koddsson @simlu @gullerya