Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test SCA passes #792

Open
imjasonh opened this issue Oct 25, 2023 · 2 comments
Open

Test SCA passes #792

imjasonh opened this issue Oct 25, 2023 · 2 comments

Comments

@imjasonh
Copy link
Member

#788 adds SCA checks to generate runtime deps based on filesystem properties. We have a handful of these. What we don't have are tests that any of this works the way we expect.

Let's add test infra to make testing this SCA behavior easier, and use it to bolster our tests.

@kaniini
Copy link
Contributor

kaniini commented Oct 25, 2023

I have already been thinking about this for some time.

I think the SCA engine should be moved into its own package, and the actual dependency generators refactored to take a filesystem as input, alongside a config.Dependencies as output.

I can queue up some PRs to do this.

@Elizafox
Copy link
Contributor

Is this a dupe of #684?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants