Centralize SOURCE_DATE_EPOCH parsing. #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before we could get into weird situations where `SOURCE_DATE_EPOCH=""` particularly with Makefiles doing conditional setting. os.LookupEnv will treat "" as the env being set (https://go.dev/play/p/sOI08BfjdhV) which means that we can get inconsistent behavior where the melanage build will default SOURCE_DATE_EPOCH to 0, but the SBOM generation would not. This consolidates the parsing behavior so we are consistent everywhere we are parsing the environment var. Signed-off-by: Billy Lynch <[email protected]>
jennpeare
approved these changes
Oct 19, 2023
imjasonh
reviewed
Oct 19, 2023
imjasonh
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we could get into weird situations where
SOURCE_DATE_EPOCH=""particularly with Makefiles doing conditional setting. os.LookupEnv will treat "" as the env being set (https://go.dev/play/p/sOI08BfjdhV) which means that we can get inconsistent behavior where the melanage build will default SOURCE_DATE_EPOCH to 0, but the SBOM generation would not.This consolidates the parsing behavior so we are consistent everywhere we are parsing the environment var.
Melange Pull Request Template
Functional Changes
Notes:
SCA Changes
Notes:
Linter
Notes: