Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch burning with ERC721ABurnable implementation #455

Open
web3sOAmazing opened this issue Mar 14, 2023 · 2 comments
Open

Batch burning with ERC721ABurnable implementation #455

web3sOAmazing opened this issue Mar 14, 2023 · 2 comments

Comments

@web3sOAmazing
Copy link

Hey, community
Is there any way to be able to batch burning with ERC721A implementation?

abstract contract ERC721ABurnable is ERC721A, IERC721ABurnable {
    /**
     * @dev Burns `tokenId`. See {ERC721A-_burn}.
     *
     * Requirements:
     *
     * - The caller must own `tokenId` or be an approved operator.
     */
    function burn(uint256 tokenId) public virtual override {
        _burn(tokenId, true);
    }
}

Cannot see any option (For example adding quantity and startTokenId instead of tokenId) similar with _beforeTokenTransfers

function _beforeTokenTransfers(
        address from,
        address to,
        uint256 startTokenId,
        uint256 quantity
    ) internal virtual {}

Only can burn one token at once?

@nidhhoggr
Copy link

A quick look at the code suggests batch burns are currently not supported, and batch transfers are not implemented, but there is an open pull request regarding the feature:

#444

@Nlferu
Copy link

Nlferu commented Nov 5, 2024

@web3sOAmazing

Those features have been recently implemented along with batchTransfer and I have already tested it and it works perfect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants