Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pty.js is unmaintained. Look into using node-pty instead? #327

Open
Dwood15 opened this issue Dec 24, 2017 · 2 comments · May be fixed by #328
Open

pty.js is unmaintained. Look into using node-pty instead? #327

Dwood15 opened this issue Dec 24, 2017 · 2 comments · May be fixed by #328

Comments

@Dwood15
Copy link

Dwood15 commented Dec 24, 2017 •
edited
Loading

blessed/lib/widgets/terminal.js

Line 218 in eab243f

this.pty = require('pty.js').fork(this.shell, this.args, {

It's been 2 years since pty.js has updated, and so swapping the pty.js require out for node-pty, which is being maintained may be prudent.

I and a couple others on the reswitched discord have run into some issues with this legacy dep. We'll do more testing, but you should be able to swap the require out without issue.
@Dwood15
Copy link
Author

Dwood15 commented Dec 24, 2017

In particular, node-pty does not break on Windows, whereas regular pty does.

@Dwood15 Dwood15 linked a pull request Dec 26, 2017 that will close this issue
Open
@ghalestrilo ghalestrilo mentioned this issue Dec 22, 2020
Open
@kkontosis
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update pty.js to node-pty. Dwood15/blessed
2 participants
@Dwood15 @kkontosis