Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mapkit JS type definitions not working #20

Closed
javiercr opened this issue Aug 2, 2019 · 5 comments
Closed

Mapkit JS type definitions not working #20

javiercr opened this issue Aug 2, 2019 · 5 comments
Assignees

Comments

@javiercr
Copy link

javiercr commented Aug 2, 2019

At the moment this package depends on wsmd/mapkit-typescript, which has some incorrect type definitions, and requires changes to tsconfig.json in order to work.

Also, the dependecy on mapkit-typescript is defined as a development dependency, so that when this package is installed, the mapkit type definitions aren't included.

As discussed in #18, this package should make sure that any consumer gets the type definitions for mapkit, and maybe it should move to @types/apple-mapkit-js, defined here, which at the moment is a bit outdated but could be fixed.

@chrisdrackett
Copy link
Owner

@chrisdrackett
Copy link
Owner

I'm wondering if in the short term it makes sense to just copy the types from https://github.com/wsmd/mapkit-typescript/ directly into this package. Not a long term solution at all, but at least would make types for react-mapkit work right away

@javiercr
Copy link
Author

javiercr commented Aug 2, 2019

That could make sense. I've been trying to find out how to bundle all the type definitions from wsmd/mapkit-typescript into a single index.d.ts so that we can submit a PR to DefinitelyTyped, but haven't succeed yet.

@chrisdrackett chrisdrackett self-assigned this Aug 6, 2019
@chrisdrackett
Copy link
Owner

an update to DT is in progress here: DefinitelyTyped/DefinitelyTyped#37415

@chrisdrackett
Copy link
Owner

well that was a pain. I think I'm just going to move the types into this project for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants