Unsupported URI schema in app_icon for desktop notifications

[jsonmaf1a]

Describe the bug

There are at least two ways to send desktop notifications in Tauri apps:

• Notification Web API:
  According to the Notifications API Standard, it should support URLs for icons. But this does not seem to work in Tauri, idk why.

• Notification Tauri API, which just uses notify-rust crate under the hood:
  Only supports file:/// URIs for icons, as stated by the notify-rust crate documentation.

In Cinny, notifications use a URL for the icon, which is received as app_icon by the desktop notification server. However, this is unsupported according to the Freedesktop.org notifications specification. As a result, notifications on Linux are rendered without an icon.

Reproduction

1. Receive a desktop notification.
2. Observe that the notification icon is missing.

Expected behavior

Notifications should display an icon.

Platform and versions

1. OS: Arch Linux
2. Cinny version: 4.1.0
3. Matrix homeserver: matrix.org
4. Downloaded from: local build

Additional context

Also, I believe you should try to pass icon as image-path or image-data and not app_icon, and the app_icon should probably be "cinny" or something.
Doing that allows the server to either display the image (if there is one), the icon (if there is no image, as a fallback) or both (for rare servers that support it).

[jsonmaf1a]

i need to do some research, so I'll close this issue for a while