Fix generation of cloudflare_access_application #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nce when handling policy response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #734
The Cloudflare API response for
ListAccessApplicationsseems to contain much more policy-related data than is necessary to generate the Terraform manifests, which only require the policy IDs.writeAttrLinepanics on this data as it is of unexpected format.This PR remaps the policy data to only keep the IDs of the policies associated with each application.
I have tested this locally, but have not added any unit tests as they seem to require API key access for specific zones/accounts for the regeneration part. Happy to add some if there's any guidelines on the process.