-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parse_gctx: don't sort returned values #36
Comments
Hi @dllahr! Not sure I totally follow. Do you mean just for the metadata only options? Otherwise the IDs are subsetted before hyperslab selection occurs. |
Sorry, no I mean that right now when you get the metadata back (and I think when you get it all back) all of the ID's have been sorted. The use-case I ran into was:
|
Ok, gotcha. That does seem like a useful thing to do. Maybe we can start with having it as an option and see how things go? |
@oena Has this been taken up? I was thinking of working on this. |
@dllahr did you follow up on this? No worries if not, just checking |
Sorry I'm late replying, I did not get to doing anything with this. |
Issue #36 (add sort option for parse gctx)
Hi @oena @levlitichev
I was thinking about doing a pull request where I modified parse_gctx to not return the dataframes sorted by index/column. The reason I propose this is if you read them out and get them in the order that they appear in the file, you can then choose the ones you are interested in, figure out their index id, and then use the ridx/cidx option to load them, which is much faster.
Also, could make it an option to do the sort. What do you think?
The text was updated successfully, but these errors were encountered: