Add additional information in gemspec #81
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 14, 2020 21:30
- Add required Ruby version - Add License - Add required Rails version - Add deprecation warning for breaking changes
Rails 5.2 will be supported in the next major version
|
|
||
| s.files = Dir["{lib}/**/*", "LICENSE", "Rakefile", "README.md"] | ||
| s.post_install_message = <<-POST_INSTALL | ||
| 1.2.x will be the last version to support Ruby < 2.4 and Rails < 5. |
There was a problem hiding this comment.
Should we start the message as a Deprecation Warning: ?
There was a problem hiding this comment.
That is generally used for classes. Maybe we should add another for FindSubclasses instead?
There was a problem hiding this comment.
Yes! that works better. Since the plan is to remove the class, it would be better to warn the usage of the class as well 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #80