Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doesn't work? #34

Closed
DimitriPapadopoulos opened this issue Aug 22, 2021 · 2 comments · May be fixed by #32
Closed

Doesn't work? #34

DimitriPapadopoulos opened this issue Aug 22, 2021 · 2 comments · May be fixed by #32

Comments

@DimitriPapadopoulos
Copy link
Collaborator

I may be doing something stupid, but this does not seem to be working, codespell does not detect any errors:

 6 Running codespell on '' with the following options...
 7 Check filenames? 'true'
 8 Checking filenames
 9 Check hidden? ''
10 Exclude file ''
11 Skipping 'spelling.txt,LICENSE.OpenSSL'
12 Builtin dictionaries ''
13 Ignore words file ''
14 Ignore words list ''
15 Resulting CLI options  --check-filenames --skip spelling.txt,LICENSE.OpenSSL
16 0
17 Codespell found no problems

See pull request adrienverge/openfortivpn#921 and the .github/workflos/codespell.yml file

---
name: Codespell

on:
  push:

  pull_request:
    branches:
      - master

jobs:
  codespell:
    name: Codespell
    runs-on: ubuntu-latest

    steps:
      - name: Run Codespell
        uses: codespell-project/actions-codespell@master
        with:
          check_filenames: true
          skip: spelling.txt,LICENSE.OpenSSL
@DimitriPapadopoulos
Copy link
Collaborator Author

After a look at your own .github/workflows/codespell.yml, I added:

      - uses: actions/checkout@v2

just before:

      - uses: codespell-project/actions-codespell@master

@DimitriPapadopoulos
Copy link
Collaborator Author

Much better! Perhaps you could add an example to the documentation in README.md.

@peternewman peternewman linked a pull request Sep 22, 2021 that will close this issue
Add checkout action and problem matcher to README #32
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add checkout action and problem matcher to README vadi2/actions-codespell
1 participant
@DimitriPapadopoulos