-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring the Website: Card design #48
Comments
Hi @Aniket-Mishra, what part of the projects need change? Are you referring to the following? Lines 439 to 499 in 053350e
What shall happen instead? This issue was assigned to @sureshmangs. Does that mean it's no longer up for grabs? |
@Ryuno-Ki Yeah, you can work on it. |
Cool. What do you need? Do you have a picture or something I can work towards, too? What is the objection of the cards? I want to understand the problem before I work towards a solution :-) |
So I took a closer look into the current setup and discovered, that you use materialize.css Cards at the moment. However, issues like Dogfalo/materialize#2089 didn't receive an update and I couldn't find another documentation about how to do that within the framework. So I applied a trick I learned by Chris Coyier and went with CSS Grid. With my change, it will become: (Tested in Firefox and Chromium, since I'm using Sabayon Linux). Is it what you want? Do you need some additional adjustments? (e.g. colours) I'm going to open a PR now. We can iterate there, if you have further wishes. Cool with you? |
I've noted, that the branch shall branch off off There, you're already using a |
Hey @Ryuno-Ki , I'd made the issue because the original website has way too many redundant libraries and is written poorly. I was thinking of rebuilding the whole website without the code. I'd used materialize.css and a bunch of jQuery plugins, which I now realize were not needed. |
Add hover effect to cards. Limit container width. Refs #48
I see. Can you scribble some ideas on a napkin and upload a photo of it? I'd add some HTML comments to ease the job of what element a closing tag belongs to in a subsequent PR. What would be needed to resolve this one? You already have the projects with card pattern now. |
Use branch: refactoring-the-website
The design of the cards in projects needs to be changed.
The text was updated successfully, but these errors were encountered: