Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New loguru logging seems not to play nice with Python logging. #93

Open
sarusso opened this issue Jan 7, 2024 · 1 comment
Open

New loguru logging seems not to play nice with Python logging. #93

sarusso opened this issue Jan 7, 2024 · 1 comment

Comments

@sarusso
Copy link
Contributor

sarusso commented Jan 7, 2024

Hi,

commit 61d9845 introduced loguru, but it seems to me that right now it's just using Python root logger under the hood, as it might not be properly set up (as mentioned in https://github.com/Delgan/loguru?tab=readme-ov-file#suitable-for-scripts-and-libraries)

The result is that it becomes hard to include Fitter v1.7.0 in other applications that might need to change logleves, use other handlers or just hide its output. In this sense, it was better to use Python's standard logging.

I am not sure what the solution could be, but right now I am forced to monkey-patch Fitter at runtime to be able to take control over its logging.

@sarusso sarusso changed the title New logging seems not to play nice with Python loggign. New loguru logging seems not to play nice with Python logging. Jan 7, 2024
@cokelaer
Copy link
Owner

dear @sarusso thanks for reporting this issue. indeed, I naively used loguru and I believe this is not really what I wanted. I need to look a bit more at the doc you sent and will probably roll back to previous version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants