From db863232438e1e515c61147f47e948ec4755f67e Mon Sep 17 00:00:00 2001 From: Simen Mailund Svendsen Date: Fri, 25 Oct 2024 14:54:11 +0200 Subject: [PATCH 1/3] specify grpc as appprotocol in cfn exmaple, needed to properly export traces --- aws-integrations/ecs-fargate/ecs-fargate-cf.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/aws-integrations/ecs-fargate/ecs-fargate-cf.yaml b/aws-integrations/ecs-fargate/ecs-fargate-cf.yaml index 68358ccc..73df0ecf 100644 --- a/aws-integrations/ecs-fargate/ecs-fargate-cf.yaml +++ b/aws-integrations/ecs-fargate/ecs-fargate-cf.yaml @@ -226,9 +226,11 @@ Resources: - ContainerPort: 4317 HostPort: 4317 Protocol: tcp + AppProtocol: grpc - ContainerPort: 4318 HostPort: 4318 Protocol: tcp + AppProtocol: grpc Essential: false Command: ["--config", "env:SSM_CONFIG"] Environment: @@ -285,4 +287,4 @@ Resources: Resource: !Sub arn:aws:ssm:${AWS::Region}:${AWS::AccountId}:parameter/${OTELConfigParameter} Roles: - - !Ref ECSExecutionRole \ No newline at end of file + - !Ref ECSExecutionRole From a828f1c7e73a20f4fa7ff6a4403c1c1d2223e4b8 Mon Sep 17 00:00:00 2001 From: Simen Mailund Svendsen Date: Fri, 25 Oct 2024 15:00:21 +0200 Subject: [PATCH 2/3] update changelog --- aws-integrations/ecs-fargate/CHANGELOG.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/aws-integrations/ecs-fargate/CHANGELOG.md b/aws-integrations/ecs-fargate/CHANGELOG.md index adb07609..23aecb9c 100644 --- a/aws-integrations/ecs-fargate/CHANGELOG.md +++ b/aws-integrations/ecs-fargate/CHANGELOG.md @@ -5,6 +5,9 @@ +### 0.0.7 / 2024-10-25 +* [CHANGE] Specify grpc as appProtocol, needed to properly export traces. + ### 0.0.6 / 2024-10-18 * [UPDATE] Update ecs-fargate integration cf to allow larger "Advanced" Parameter Store. * [UPDATE] Adjust roles to true minimum requirements. From 0b913340f92fb3512a494ef43bb6060e4f0a0433 Mon Sep 17 00:00:00 2001 From: Simen Mailund Svendsen Date: Fri, 25 Oct 2024 15:34:46 +0200 Subject: [PATCH 3/3] 4318 should be http --- aws-integrations/ecs-fargate/ecs-fargate-cf.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/aws-integrations/ecs-fargate/ecs-fargate-cf.yaml b/aws-integrations/ecs-fargate/ecs-fargate-cf.yaml index 73df0ecf..a8b05aa2 100644 --- a/aws-integrations/ecs-fargate/ecs-fargate-cf.yaml +++ b/aws-integrations/ecs-fargate/ecs-fargate-cf.yaml @@ -230,7 +230,7 @@ Resources: - ContainerPort: 4318 HostPort: 4318 Protocol: tcp - AppProtocol: grpc + AppProtocol: http Essential: false Command: ["--config", "env:SSM_CONFIG"] Environment: