Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple protodepUp task from zio-grpc #6

Open
thesamet opened this issue Dec 31, 2020 · 1 comment
Open

Decouple protodepUp task from zio-grpc #6

thesamet opened this issue Dec 31, 2020 · 1 comment

Comments

@thesamet
Copy link
Contributor

Thanks for putting this plugin together! I think the plugin can become more modular if users of ProtodepPlugin can use it without opting in to zio-grpc. To accomplish this, protoDepUpTask can be moved to ProtodepPlugin, and GrpcDependencies can enable ProtoDep (rather than the other way around). This would let users who use ProtodepPlugin but not GrpcDependencies to set their own PB.targets.

@vigoo
Copy link
Contributor

vigoo commented Jan 4, 2021

Thanks! I agree, this came out from an internal project where we are using it for zio-grpc projects, but could be more generic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants