Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition to SASS #50

Open
VoyTechnology opened this issue Jul 20, 2018 · 0 comments
Open

Transition to SASS #50

VoyTechnology opened this issue Jul 20, 2018 · 0 comments

Comments

@VoyTechnology
Copy link
Member

This is a bit tricky. SASS would definitely improve the ease of writing the styling for the page. However there are certain problems right now.

Hugo has added experimental pipes in 0.43, but they are being guarded by extended build flag (in 0.44). Everything is fine from the CI side, we can just download the hugo_extended binaries and build with the pipe, however problems arise on the development side, as only the standard (pipe-less) build is provided using package managers. This would mean every person contributing would be in charge of manually updating to latest version of hugo, which can get messy, as #30 showed where I have build the side using 0.38-dev instead of latest 0.44, resulting in series of bugs.

There are 4 solutions we can take:

  1. Keep the styling as-is, using traditional CSS 👎
  2. Create the stylesheet using additional build step before actually deploying to the site, and once pipes enter mainstream, switch to pipes 😆
  3. Use hugo-extended pipes and force everyone to download latest extended version 😕

Vote using reactions or comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant